Fix #5374: Add async request blocking via webkit message handlers by cuba · Pull Request #5444 · brave/brave-ios (original) (raw)

Skip to content

Navigation Menu

• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

This repository was archived by the owner on May 10, 2024. It is now read-only.

Merged

iccub

merged 2 commits into

Jul 8, 2022

Conversation

Summary of Changes

This pull request fixes #5374

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()

Test Plan:

This is a tricky to test feature:

1. You may test by building the debug version of the application and seeing if no javascript errors are thrown on the injected scripts.
2. Go to a few sites with known trackers and test that nothing is broken. (YouTube, Facebook, instagram, etc)3.

Test 2:

1. Switch languages to something that uses regional lists. (ex switch phone to the polish)
2. Go to twitter and make sure the login works

Screenshots:

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No) - test for performance degradation
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue and pull request is assigned to a milestone (should happen at merge time).

cuba requested a review from a team

June 6, 2022 16:19

cuba marked this pull request as ready for review

June 6, 2022 16:19

cuba mentioned this pull request

Jun 29, 2022

7 tasks

iccub deleted the js/5374-request-blocking branch

July 8, 2022 20:32

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})