better error message for crosscheck when dictionary checks fail. by yfarjoun · Pull Request #1982 · broadinstitute/picard (original) (raw)

Description

when many files are included in a crosscheck and a few of the files contain a problematic dictionary the exception will appear after all the files have been processed, but the error message will not inform the user of the problematic file(s). This change solves that by wrapping the fingerprinting calls in a try/catch and logging an error when this happens.

Moves the log message above the checkdictionary call and wraps fingerprinting in a try/catch to get an informative error message regarding the name of the file that caused the problem

Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

• Added or modified tests to cover changes and any new functionality
• Edited the README / documentation (if applicable)
• All tests passing on github actions

Review

• Final thumbs-up from reviewer
• Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests