fix(types): exclude DeepPartial<unknown[]> from ChartOptions interface by artus9033 · Pull Request #11867 · chartjs/Chart.js (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

etimberg

merged 2 commits into

Aug 16, 2024

Conversation

@artus9033

This PR solves #11866 by excluding DeepPartial<unknown[]> from ChartOptions.

Closes #11866.

@artus9033

etimberg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense. Not sure why the CI is failing though since it seems unrelated

@artus9033

Thanks @etimberg! Oh, I can see that now - I haven't run ESLint locally and it seems like my formatting is not compliant with the rules - I'll fix that.

@artus9033

LeeLenaleee

etimberg

[Snyk] Upgrade: , , , , , , , , , , , , tslib, , , chart.js, dotenv, ng-zorro-antd, openai, pdfmake, primeng, zone.jsdiaz-rigo/austins#23

Open

[Snyk] Upgrade: body-parser, chart.js, cloudinary, dotenv, ejs, express, express-session, formidable, mongodb, mongoose, passport, swipermytamDo/ATBMHTTT_SSRFWebDemo#12

Open

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Labels