simplify "Compiling" info message: display relative path by hboutemy · Pull Request #250 · codehaus-plexus/plexus-compiler (original) (raw)
Conversation
simplify current info message
[INFO] Compiling 29 source files to /full/path/to/project/which/is/very/noisy/target/test-classes
by replacing full path with relative to basedir:
[INFO] Compiling 29 source files to target/test-classes
| getLogger().info( "Compiling " + sourceFiles.length + " " + |
|---|
| "source file" + ( sourceFiles.length == 1 ? "" : "s" ) + |
| " to " + destinationDir.getAbsolutePath() ); |
| " to " + to ); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these duplications be avoided?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these duplications be avoided?
?? not sure to understand your concern?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to and message logged/being output are calculated twice (Javac, AspecJCompiler) in the same way.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})