ensure prompter does not double colon by rmannibucau · Pull Request #10 · codehaus-plexus/plexus-interactivity (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Conversation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether the colon should be in the default reply at all. But it could also be a question so it is not our task to complete the sentence...
well fact is writePrompt (any prompt method) will always issue a ':' so any consumer of this API expects that but in defaultReply case it issues it twice which is a bug so the fix is sufficient. If we want to handle the question we need to add another promptQuestion method or something equivalent to enable to customize it but it is a new feature/API IMHO and this one would likely bypass the Prompter API to use the OutputHandler one directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})