Update gomod dependabot to use directories by djdongjin · Pull Request #1920 · containerd/stargz-snapshotter (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

ktock

merged 1 commit into

Jan 7, 2025

Conversation

@djdongjin

  1. Move repeated gomod sections to a single one by using directories instead of directory.
  2. Add a few groups: update deps matching the groups pattern in a single PR.
    a. One benefit of this is dependabot will update the deps in all go.mods, thus the CI can pass (otherwise it may fail due to requiring go mod tidy.
    b. I think a should be true regardless if groups is used or not. But from my experience, it seems dependabot only do this for groupsed deps, and still open different PRs for different modules if a dep is not part of a group.

@ktock

Could you rebase this on the latest main branch to enable CI?

@djdongjin

Signed-off-by: Jin Dong djdongjin95@gmail.com

@djdongjin

Could you rebase this on the latest main branch to enable CI?

no problem, done.

ktock

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

2 participants

@djdongjin @ktock