fix: rm packages/main/src/assets from extra resources to get included into app.asar by dgolovin · Pull Request #9514 · podman-desktop/podman-desktop (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks13 Files changed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Apparently extra resources have higher priority and files included in extra resource are getting dropped out of reqular resources included into app.asar file.
What does this PR do?
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?
- Tests are covering the bug fix or the new feature
… in app.asar
Apparently extra resources have higher priority and files included in extra resource are getting dropped out of reqular resources included into app.asar file.
Signed-off-by: Denis Golovin dgolovin@redhat.com
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried the dmg and was able to launch
codesign --force --deep --sign - "./Podman Desktop.app"
xattr -r -d com.apple.quarantine "./Podman Desktop.app"
@dgolovin if you can try these instructions
fix: rm packages/main/src/assets from extra resources to get include into app.asar fix: rm packages/main/src/assets from extra resources to get included into app.asar