Support 1.23 iterator for set by amikai · Pull Request #140 · deckarep/golang-set (original) (raw)

@amikai and @freeformz - it looks like you both want your PR’s merged on Iterator support for this package.

I appreciate both of your efforts on this but both PR’s are quite different. freeformz looks to be a significant change at the moment while amikai’s is much smaller in scope and looks to be much more straightforward.

Let me be be clear: I want to support iterators but when this was initially proposed it felt too early to just jump in without a better understanding of the best way forward. This is why I didn’t rush to merge it. It’s also why I don’t rush to merges everyone’s changes.

Some significant projects are using this package and any abrupt changes which cause confusion, frustration will cause these projects to quickly fork and/or abandon this repo.

So as it stands I’m interested in taking the least breaking changes, with the least scope currently. Additionally, I want to ensure that methods are deprecated overtime and not overnight.

So with all of that said, @amikai - it seems like the last thing we had to come to agreement on was just the naming of the iterator method? And it looks like Values should work just fine?

@freeformz - your input is still welcome but I want to introduce smaller scopes changes at this time. As more people migrate to later versions of Go I will consider cutting a V3 release.