Introduce new errors for unsupported driver behaviors by jedevc · Pull Request #1188 · docker/buildx (original) (raw)

For the node update, if we are allowing flags then I don't see a reason why we would error on driveropt/config.

I think at the very least we should warn here - we allow the --driver-opt flag on a node update, but it will be silently discarded. The flag has to be accepted here since it's the same create subcommand that we use to create drivers in the first place.

Will update the PR to do this.

For the mixed drivers, looks like an oversight as well. Although this one is harder to fix. I don't see a specific reason why this should not be allowed. All the driver instances are passed separately to the build function. They do not need to be of the same type there.

True. However, the way we store the drivers in config makes this harder to do - the driver is attached to the NodeGroup, so to do this we'd need to push down the driver config into each individual Node, not quite sure what implications that would have, but seems like an interesting possibility 👀