cli/flags: remove special quote handling for --tlsXXX flags by thaJeztah · Pull Request #6306 · docker/cli (original) (raw)

This non-standard handling for these options was added in moby@e4c1f07 and moby@abe32de to work around a regression in Docker 1.13 that caused docker-machine to fail. Preserving quotes in such cases is expected (and standard behavior), but versions of Docker before 1.13 used a custom "mflag" package for flag parsing, and that package contained custom handling for quotes (added in moby@0e9c40e).

Given that Docker Machine reached EOL a long time ago and other options, such as docker context, have been added to configure the CLI to connect to a specific host (with corresponding TLS configuration), we can remove the special handling for these flags, as it's inconsistent with all other flags, and not worth maintaining for a tool that no longer exists.

Signed-off-by: Sebastiaan van Stijn github@gone.nl

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})