bump Golang version to v1.22.10 and update CI actions by glours · Pull Request #12399 · docker/compose (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks26 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

What I did
Bump Golang to v1.22.10 and update the different GitHub actions

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

uses: tibdex/github-app-token@v1
uses: tibdex/github-app-token@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 3rd party action, so potentially less "trusted"; wondering if this is one that we should pin to a commit? (also make sure that we evaluate the changes in the release).

Diff since last (v1.9.0) v1 release (but perhaps there's been other v1 updates since it was added); tibdex/github-app-token@v1.9.0...v2.1.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned the version to the v2.1.0 commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

glours requested review froma team and ndeloof and removed request fora team

December 18, 2024 14:41

Comment on lines -144 to +146

- 24.0.9
- 25.0.5
- 26.1.4
- 27.4.0-rc.4
- 27.4.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a check if the script would be fine with that, but it looks like it is; it's possible to specify just 27.4 or even just 27, and it will pick the latest 27.4.x or 27.x.x. That may be ok to consider to not having to update for each minor or patch release.

I'll also check with @vvoland and @crazy-max to see if we can swap this out for our new docker-setup-action (https://github.com/docker/setup-docker-action), but that can definitely wait for separate for sure!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it should work! It also supports master (with type=image,tag=master) so it could also be tested against here.