Only override service mac if set on the main network. by apollo13 · Pull Request #12439 · docker/compose (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation1 Commits1 Checks24 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
What I did
I am using compose against podman which exposes API 1.41 and as such does not yet support mac per network. But the existing code unconditionally overrides the mac address set on the service level with the mac from the main network even if none is defined -- hence only override if it is actually set.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
Signed-off-by: Florian Apolloner florian@apolloner.eu
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request
2 participants
