Fix pull --parallel and --no-parallel deprecation warnings missing by maxproske · Pull Request #12555 · docker/compose (original) (raw)

What I did

I believe --no-parallel was mistakenly bound to opts.parallel and as a result, the deprecation warning in the PreRunE hook was never printed. Fixed the binding, and added a matching deprecation warning for --parallel.

Before (No deprecation warnings in stderr):

compose.yaml

services: app: image: nginx:latest

$ docker compose pull --parallel=false
[+] Pulling 1/1
 ✔ app Pulled

$ docker compose pull --no-parallel
[+] Pulling 1/1
 ✔ app Pulled

After:

$ ./docker-compose pull --parallel=false
option '--parallel' is DEPRECATED and will be ignored.
[+] Pulling 1/1
 ✔ app Pulled

$ ./docker-compose pull --no-parallel
option '--no-parallel' is DEPRECATED and will be ignored.
[+] Pulling 1/1
 ✔ app Pulled