don't display bake suggestion when using --progress with quiet or json option by glours · Pull Request #12561 · docker/compose (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation1 Commits1 Checks28 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
What I did
To avoid breaking potential json parting and respect quiet option of progress mode, I removed bake suggestion's print
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
…n option
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 51.69%. Comparing base (49575ef) to head (38ea33d).
Report is 19 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #12561 +/- ##
Coverage 51.78% 51.69% -0.10%
Files 156 156
Lines 15697 15693 -4- Hits 8129 8112 -17
- Misses 6763 6772 +9
- Partials 805 809 +4
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request
2 participants
