make publish a regular command of Compose by glours · Pull Request #12629 · docker/compose (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks28 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
What I did
Move publish
away from the alpha
command umbrella
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
@@ -46,7 +46,7 @@ func publishCommand(p *ProjectOptions, dockerCli command.Cli, backend api.Servic |
---|
RunE: Adapt(func(ctx context.Context, args []string) error { |
return runPublish(ctx, dockerCli, backend, opts, args[0]) |
}), |
Args: cobra.ExactArgs(1), |
Args: cli.RequiresMinArgs(1), |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change ? Don't we only support a single (required) arg for this command ?
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
ndeloof deleted the move-publish-to-main-cmd branch
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request
2 participants