Unquarantine Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams by amcasey · Pull Request #57471 · dotnet/aspnetcore (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks26 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

amcasey

The test has been rewritten, looks thread-safe, and hasn't failed in 30 days.

Fixes #30309

@amcasey

…amsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams

The test has been rewritten, looks thread-safe, and hasn't failed in 30 days.

Fixes dotnet#30309

This was referenced

Aug 22, 2024

@amcasey amcasey changed the titleUnquarantine Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams Fix Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams

Aug 22, 2024

@amcasey

CI failures are known. I won't bother to re-run until people have reviewed.

@JamesNK JamesNK changed the titleFix Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams Unquarantine Frame_MultipleStreams_RequestsNotFinished_DefaultMaxStreamsPerConnection_EnhanceYourCalmAfterDoubleMaxStreams

Aug 22, 2024

JamesNK

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on the issue name 😄

@amcasey

nit on the issue name 😄

I fixed the others, but I think this one actually is unquarantining.

Edit: Oh, I see, I overcorrected. 😆

Labels

area-networking

Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

task