[release/9.0] Readd DiagnosticSource to KestrelServerImpl by github-actions[bot] · Pull Request #60202 · dotnet/aspnetcore (original) (raw)

Backport of #60129 to release/9.0

/cc @BrennanConroy

Readd DiagnosticSource to KestrelServerImpl

Description

During 8.0 we did a bunch of metrics work and accidentally removed DiagnosticSource support in Kestrel. We document how to monitor your app for bad requests and it doesn't work anymore.

Fixes #58911

Customer Impact

Our docs on how to monitor your app for bad requests doesn't work anymore. Customers would instead need to rely on/add logging capturing for this scenario if they even notice that the feature is broken.

1st party as well as a couple customers have hit this.

Regression?

• Yes
• No

Regressed in .NET 8

Risk

• High
• Medium
• Low

Simple fix, added smoke test to verify, and did a manual test to check it works now.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No