Update .NET SDK to 10.0.100-preview.3.25122.1 by github-actions[bot] · Pull Request #60564 · dotnet/aspnetcore (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits10 Checks27 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
[![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Update .NET SDK to version 10.0.100-preview.3.25122.1.
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ...
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
[![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving SDK update.
(cherry picked from commit ab38a29)
D:\a_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\CommonLib\HostFxrResolver.cpp(17,10): error C1083: Cannot open include file: 'nethost.h': No such file or directory
we try to take it from the downloaded sdk:
| <!-- This is not correct and needs attention eventually. This is primarily used to find the nethost headers in the apphost pack. |
|---|
| These should be coming from a restored apphost pack, rather than a hard-coded local SDK. In fact, aspnetcore |
| should not rely on a local SDK or mutating one to build. --> |
| <NetCoreTargetingPackRoot Condition="'$(DotNetBuild)' == 'true'">$(DotNetRoot)packs\</NetCoreTargetingPackRoot> |
I confirmed that the sdk no longer contains the x86/arm64 apphost packs.
@ViktorHofer I think this is more fallout from your recent changes.
This difference is expected as we removed the cross-apphosts from the layout: dotnet/sdk#46911. They are getting installed via the bundles. We will need to update aspnetcore to acquire them differently.
I will take another look later this week. Let me know if merging this change in becomes more urgent.
| 143 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkoritzinsky you might have some ideas how to fix this properly? (for a follow-up)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restoring everything doesn't sound that bad to me either, curious why you didn't use PackageDownload?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restoring everything doesn't sound that bad to me either
It creates an artificial difference between the VMR and the repo build. But not the end of the world, for sure.
curious why you didn't use PackageDownload?
vcxproj restore (opt in via EnableManagedPackageReferenceSupport) doesn't support PackageDownload.
This one is finally ready :)
Reviewers
