[main] Update dependencies from dotnet/source-build-reference-packages by dotnet-maestro[bot] · Pull Request #60601 · dotnet/aspnetcore (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits11 Checks27 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

[dotnet-maestro[bot]](/apps/dotnet-maestro)

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

@dotnet-maestro

…ence-packages build 20250224.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.611901 -> To Version 10.0.612402

[dotnet-policy-service[bot]](/apps/dotnet-policy-service)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro

…ence-packages build 20250225.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.611901 -> To Version 10.0.612502

@SteveSandersonMS

@dotnet/source-build The failure here is:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25106.4/tools/SourceBuild/AfterSourceBuild.proj(83,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 4 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
System.Buffers.4.4.0
System.Collections.Immutable.1.5.0
System.Memory.4.5.3
System.Reflection.Metadata.1.6.0

The prebuild-usage is:

prebuild-usage

src/

... so it looks like all the new usages are from analyzers.

Are these things we can whitelist?

@ellahathaway

@dotnet-maestro

…ence-packages build 20250227.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.611901 -> To Version 10.0.612702

@SteveSandersonMS

@SteveSandersonMS

ellahathaway

@dotnet-maestro

…ence-packages build 20250228.4

Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.611901 -> To Version 10.0.612804

@SteveSandersonMS

@dotnet-maestro

…ence-packages build 20250303.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.611901 -> To Version 10.0.615303

@JamesNK

@JamesNK

It looks like this is still broken. Error from Build Source-Build (Managed) pipeline:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25106.4/tools/SourceBuild/AfterSourceBuild.proj(83,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 27 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NETCore.Targets.1.1.0
System.Collections.4.3.0
System.Composition.AttributedModel.1.0.31
System.Composition.Convention.1.0.31
System.Composition.Hosting.1.0.31
System.Composition.Runtime.1.0.31
System.Composition.TypedParts.1.0.31
System.Diagnostics.Debug.4.3.0
System.Diagnostics.Tools.4.3.0
System.Globalization.4.3.0
System.IO.4.3.0
System.Linq.4.3.0
System.Linq.Expressions.4.3.0
System.ObjectModel.4.3.0
System.Reflection.4.3.0
System.Reflection.Emit.4.3.0
System.Reflection.Emit.ILGeneration.4.3.0
System.Reflection.Emit.Lightweight.4.3.0
System.Reflection.Extensions.4.3.0
System.Reflection.Primitives.4.3.0
System.Reflection.TypeExtensions.4.3.0
System.Resources.ResourceManager.4.3.0
System.Runtime.4.3.0
System.Runtime.Extensions.4.3.0
System.Text.Encoding.4.3.0
System.Threading.4.3.0
System.Threading.Tasks.4.3.0

@SteveSandersonMS

@JamesNK Looks like more recent dotnet/source-build-reference-packages changes have moved the goalposts further. A lot further, in fact.

Probably best to reconfirm with @ellahathaway that we really should be adding this many prebuilts, or whether in any sense this undermines the concept of source build. Perhaps the fact that all of them are System.* and presumably produced by Microsoft makes them totally fine to add as prebuilts.

@eerhardt

@dotnet/source-build - Can this PR be assigned to someone to drive to merge?

@mthalman

@dotnet/source-build - Can this PR be assigned to someone to drive to merge?

Assigned myself

@mthalman

@mthalman

@mthalman

All the prebuilts are from the Microsoft.CodeAnalysis.Workspaces.Common package. These are no longer defined in SBRP so they are showing up here. They're ok to add to the prebuilt baseline as the Microsoft.CodeAnalysis.Workspaces.Common version will get lifted in the full product build, along with its transitive dependencies. Because all those transitive dependencies are also getting lifted, there's no need to define these as dependencies in Version.Details.xml.

ellahathaway

@eerhardt