Remove remaining String.ToLower() use from corelib by stephentoub · Pull Request #26602 · dotnet/coreclr (original) (raw)

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

stephentoub

This should not be culture-specific.

Also happens to save a string allocation, but that's a drop in the bucket in this function.

@stephentoub

Also happens to save a string allocation, but that's a drop in the bucket in this function.

filipnavara

jkotas

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request

Sep 10, 2019

@stephentoub @dotnet-bot

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request

Sep 10, 2019

@stephentoub @dotnet-bot

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

marek-safar pushed a commit to mono/mono that referenced this pull request

Sep 10, 2019

@stephentoub @marek-safar

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

stephentoub added a commit to dotnet/corefx that referenced this pull request

Sep 10, 2019

@stephentoub

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request

Sep 12, 2019

@stephentoub @dotnet-bot

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

jkotas pushed a commit to dotnet/corert that referenced this pull request

Sep 12, 2019

@stephentoub @jkotas

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot dotnet-bot@microsoft.com

picenka21 pushed a commit to picenka21/runtime that referenced this pull request

Feb 18, 2022

@stephentoub

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Commit migrated from dotnet/coreclr@4432a27