Cut string allocations for filtered watcher files by JeremyKuhne · Pull Request #29227 · dotnet/corefx (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the string-based overload still used somewhere, or could it be deleted?

EDIT: Is it sticking around purely for the Unix builds? If so, a) it'd be nice if the allocations could be removed from the unix builds in the same PR (we shouldn't be prioritizing Windows over Unix unless there's a reason similar improvements can be made on Unix), but if that's not possible for some reason, at least b) move the now Unix-specific functionality out of the shared file.