[Vision] Add support for Xcode 15 by haritha-mohan · Pull Request #19099 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation99 Commits20 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

[return: NullAllowed]
NSDictionary<NSString, NSArray> GetSupportedComputeDevices([NullAllowed] out NSError error);

// could this be combined into a Get/Set pair? docs are a bit weird..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add two api when working with smart enums, one that takes an NSString and the other one that takes the enum . The reason is that we want to expose the nicer apit with the enum and also allow a user to pass a value we might have forgotten.

[return: NullAllowed]
NSDictionary<NSString, NSArray> GetSupportedComputeDevices([NullAllowed] out NSError error);

// could this be combined into a Get/Set pair? docs are a bit weird..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 3448 to 3452


[TV(17, 0), Mac(14, 0), iOS(17, 0), MacCatalyst(17,0)]
[Export("supportedJointsGroupNamesAndReturnError:")]
[return: NullAllowed]
string[] GetSupportedJointsGroupNames([NullAllowed] out NSError error);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objc returns a string, but is in reality an enum form the one you created: VNAnimalBodyPoseObservationJointsGroupName

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline with @mandel-macaque and decided to follow what was already being done in the framework and use the BindAs attribute to improve the exposed api

This comment has been minimized.

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This comment has been minimized.

}

[Export ("parentJoint")]
string ParentJoint { get; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look at the docs, this sounds like one of the smart enums if not probably NSString is a better choice here.

string ParentJoint { get; }
NSString ParentJoint { get; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, should be a smart enum if possible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Alex Soto alex@soto.dev

This comment has been minimized.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes) .NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c8315524a1eeedf34713a83c6fe91fec86cb8228 [PR build]

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]