[WebKit] Add support for Xcode 15 by haritha-mohan · Pull Request #19237 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation38 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This comment has been minimized.

Comment on lines 31 to 35

!missing-selector! WKWebView::goBack: not bound
!missing-selector! WKWebView::goForward: not bound
!missing-selector! WKWebView:🔃 not bound
!missing-selector! WKWebView::reloadFromOrigin: not bound
!missing-selector! WKWebView::stopLoading: not bound

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne ah good catch, addressed! got confused by the selectors already present in WKWebView with the same name but without the ending ":"

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Comment on lines +1 to +4

# xcode 15
# requires OS_nw_proxy_config type which has not been bound yet, part of Xcode 15 Network binding
!missing-selector! WKWebsiteDataStore::proxyConfigurations not bound
!missing-selector! WKWebsiteDataStore::setProxyConfigurations: not bound

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haritha-mohan can you please create an issue to track this, I'll take care of it once I do the network framework.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

/sudo backport release/8.0.xx

Backport Job to branch release/8.0.xx Created! The magic is happening here

/sudo backport release/8.0.1xx

Backport Job to branch release/8.0.1xx Created! The magic is happening here

/sudo backport release/8.0.1xx

Backport Job to branch release/8.0.1xx Created! The magic is happening here