[release/8.0.1xx] [msbuild] Copy files to be signed into the correct directory for Hot Restart. Fixes #19278. by vs-mobiletools-engineering-service2 · Pull Request #19335 · dotnet/macios (original) (raw)

…Restart. Fixes dotnet#19278.

  1. Move the signing to after we copy files that must be signed into the app bundle that will be signed: we sign in the _CodesignHotRestartAppBundle target, so this means the targets _CopyHotRestartBundleResources and _CopyFilesToHotRestartSignedAppDirContents must execute first.

  2. Try to clear up some confusion about the directories involved. The HotRestartSignedAppOutputDir property indicates the location of the signed app bundle, which means no files should be added there. Instead files that should be signed (or present when the app launches) must be placed in the HotRestartAppBundlePath directory.

  3. Document each property involved to try to avoid more mistakes in the future.

Fixes dotnet#19278.