[Vision] Update Xcode 15 support by haritha-mohan · Pull Request #19412 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation85 Commits19 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This commit adds some missing bindings and fixes up some of the previous API that were incorrectly bound with Vector4 instead of Matrix4.

A sample app using some of these latest bindings can be found here: https://github.com/haritha-mohan/vision-analyzer

Fixes xamarin/maccore#2719, though the manual testing ended up not being necessary still helped catch a few bugs and showcases some of the latest work done for this xcode release.

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This comment has been minimized.


[Export ("getCameraRelativePosition:forJointName:error:")]
// MarshalDirective not needed bc Matrix4 param is passed by reference as opposed to by value as typically done
bool GetCameraRelativePosition (out Matrix4 modelPositionOut, [BindAs (typeof (VNHumanBodyPose3DObservationJointName))] NSString jointName, [NullAllowed] out NSError error);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you already have a test app, would it be possible to write a manual test for this (I'm assuming you'll need a photo for this; that can be added to the monotouch-test project as a BundleResource - the only caveat would be to try to shrink the image if possible to avoid multi-mb files in the repo :))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne yep I can do that. with the api doing significantly better when the image has depth data and also having to comply with license/copyright restrictions, I need to use an image of our own..I will try to recruit a team member from the office next week for the sample image 😀

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This comment has been minimized.

as a temp workaround, ensure that the value method for the VNHumanBodyPose3DObservationJointName smart enum does not get linked away.

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This comment has been minimized.

// the VNHumanBodyPose3DObservationJointName smart enum are linked away and results in a
// build failure.
// As a temp workaround, this test will ensure that the GetValue method is getting used
// to prevent the linker from removing this method.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment with the link to the bug report you filed would be nice.

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:) .NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7a62150b27a9d81c52cd793661297985ea5866be [PR build]

test failure unrelated - sim crash