[Generator] Move the NSValue create map to the TypeCache. by mandel-macaque · Pull Request #19495 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The dictionary needs to be init after the TypeCache. It is only natural for the TypeCache to be the owner of the dictionary.

We make the dictionary readonly to stop other code from introducing mistakes by modifying it.

The dictionary needs to be init after the TypeCache. It is only natural for the TypeCache to be the owner of the dictionary.

We make the dictionary readonly to stop other code from introducing mistakes by modifying it.

mandel-macaque changed the title[Generator] Move the NSValue to the TypeCache. [Generator] Move the NSValue create map to the TypeCache.

Nov 20, 2023

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

• iOS (no change detected)
• tvOS (no change detected)
• watchOS (no change detected)
• macOS (no change detected) NET (empty diffs)
• iOS: (empty diff detected)
• tvOS: (empty diff detected)
• MacCatalyst: (empty diff detected)
• macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes) .NET (No breaking changes)
• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist Legacy Xamarin (stable) vs .NET
• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4913a6b5b3943090ed3a2c884031549313ea1ffe [PR build]