[Generator] == on a type those a reference equals check. by mandel-macaque · Pull Request #19756 · dotnet/macios (original) (raw)

Found this while writing some unit tests for the generator. The comparison between types uses a ReferenceEquals, that means that we should ensure that we have a EcmaType in both sides. When running this on unit tests, we have a RunTime vs a EcmaType comparison which results in an error.

diff --git a/old/dotnet/IDE/obj/common/bgen/bgen.AssemblyInfo.cs b/new/dotnet/IDE/obj/common/bgen/bgen.AssemblyInfo.cs
index ef5e2e112f..5ded00c3af 100644
--- a/old/dotnet/IDE/obj/common/bgen/bgen.AssemblyInfo.cs
+++ b/new/dotnet/IDE/obj/common/bgen/bgen.AssemblyInfo.cs
@@ -13,7 +13,7 @@ using System.Reflection;
 [assembly: System.Reflection.AssemblyCompanyAttribute("bgen")]
 [assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")]
 [assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0.0")]
-[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+b60ee772c228723a5e01212471c1e8eb5c20ebb9")]
+[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+ec8a6c261a68f6aee2ad2373cf45e3f001ac4679")]
 [assembly: System.Reflection.AssemblyProductAttribute("bgen")]
 [assembly: System.Reflection.AssemblyTitleAttribute("bgen")]
 [assembly: System.Reflection.AssemblyVersionAttribute("1.0.0.0")]
diff --git a/old/dotnet/IDE/obj/common/bgen/bgen.sourcelink.json b/new/dotnet/IDE/obj/common/bgen/bgen.sourcelink.json
index 5c5105e606..547bfb2dc4 100644
--- a/old/dotnet/IDE/obj/common/bgen/bgen.sourcelink.json
+++ b/new/dotnet/IDE/obj/common/bgen/bgen.sourcelink.json
@@ -1 +1 @@
-{"documents":{"/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/*":"https://raw.githubusercontent.com/xamarin/xamarin-macios/b60ee772c228723a5e01212471c1e8eb5c20ebb9/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/external/api-tools/*":"https://raw.githubusercontent.com/rolfbjarne/api-tools/1fbbe003a141231439c08b23989d3dc910bd6182/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/external/macios-binaries/*":"https://raw.githubusercontent.com/xamarin/macios-binaries/7813391e75d7373ee073ef2d5716e3c607c8636a/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/external/MonoTouch.Dialog/*":"https://raw.githubusercontent.com/migueldeicaza/MonoTouch.Dialog/5898074d6e62109c85e587977230c1a521cb9bb2/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/external/opentk/*":"https://raw.githubusercontent.com/mono/opentk/396bc90c7ac2e7ce442840a5e8bd91e5e79b381e/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/external/Touch.Unit/*":"https://raw.githubusercontent.com/spouliot/Touch.Unit/92a072683b69b2f61f235a7a249c2c7f261236d4/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/tools/comparison/tmp/src/xamarin-macios/external/Xamarin.MacDev/*":"https://raw.githubusercontent.com/xamarin/Xamarin.MacDev/b454d454a687d9aa26a382ad16f1a9361b06b074/*"}}
\ No newline at end of file
+{"documents":{"/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/*":"https://raw.githubusercontent.com/xamarin/xamarin-macios/ec8a6c261a68f6aee2ad2373cf45e3f001ac4679/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/external/api-tools/*":"https://raw.githubusercontent.com/rolfbjarne/api-tools/1fbbe003a141231439c08b23989d3dc910bd6182/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/external/macios-binaries/*":"https://raw.githubusercontent.com/xamarin/macios-binaries/7813391e75d7373ee073ef2d5716e3c607c8636a/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/external/MonoTouch.Dialog/*":"https://raw.githubusercontent.com/xamarin/MonoTouch.Dialog/5898074d6e62109c85e587977230c1a521cb9bb2/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/external/opentk/*":"https://raw.githubusercontent.com/mono/opentk/396bc90c7ac2e7ce442840a5e8bd91e5e79b381e/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/external/Touch.Unit/*":"https://raw.githubusercontent.com/spouliot/Touch.Unit/92a072683b69b2f61f235a7a249c2c7f261236d4/*","/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/external/Xamarin.MacDev/*":"https://raw.githubusercontent.com/xamarin/Xamarin.MacDev/b454d454a687d9aa26a382ad16f1a9361b06b074/*"}}
\ No newline at end of file

API should result in no changes.