Prevent diagnostics on .NET SDK 8.0.100 by idg10 · Pull Request #2049 · dotnet/reactive (original) (raw)
added 3 commits
- disabled several entirely
- fixed some easy ones
In most cases, we now just use the new (C# 12.0) collection expression syntax. However, we've disabled IDE0305 because it makes suggestions that aren't an obvious improvement. It wants to rewrite use of ToArray() to be a collection expression. E.g. something.ToArray() would become [.. something]. Perhaps that will seem natural once we've all got used to spreads in collection expressions, but to me (idg10) today that looks odd.
Make UWP test runner use the same warning settings as everything else, except for CS0618, which a large number of tests appear to depend on.
Prevent diagnostic on .NET SDK 8.0.100 Prevent diagnostics on .NET SDK 8.0.100
idg10 added a commit that referenced this pull request
Address collection expression diagnostics
In most cases, we now just use the new (C# 12.0) collection expression syntax. However, we've disabled IDE0305 because it makes suggestions that aren't an obvious improvement. It wants to rewrite use of ToArray() to be a collection expression. E.g. something.ToArray() would become [.. something]. Perhaps that will seem natural once we've all got used to spreads in collection expressions, but to me (idg10) today that looks odd.
Add comment explaining why we've disable IDE0290
Make UWP test runner use the same warning settings as everything else, except for CS0618, which a large number of tests appear to depend on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})