Prevent trimmer warnings on current SDK by idg10 · Pull Request #2308 · dotnet/reactive (original) (raw)
added 3 commits
- From .NET FX 4.8 to .NET 10
- Code gen now null-aware
- Removed unnecessary Qbservable.NAry.tt because the HomoIcon tool handles these methods just fine
- Replace MethodBase.GetCurrentMethod with delegate (because the trimmer understands the latter but not the former)
- Suppress warning on ObservableEx
- Use C# type names in comments for decimal and float, not runtime names
Add new .Homoicon.cs extension to list skipped in license header test. (No longer using .Generated.cs because that was causing us not to see diagnostics for any of the HomoIcon-generated code.)
The IQbservable forms of the tuplet-based versions of these operators all go up to 16 arguments, but for some reason the IObservable forms go up only to 8. Since we've resurrected the HomoIcon tool, this discrepancy has caused a problem: the code gen only generates IQbservable forms corresponding to IObservable forms, and so we end up with the IQbservable API surface area shrinking.
To avoid that, this expands the IObservable CombineLatest and Zip operators to match what IQbservable was already offering.
idg10 marked this pull request as ready for review
idg10 deleted the feature/trim-warnings branch
idg10 mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})