Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default by stephentoub · Pull Request #104202 · dotnet/runtime (original) (raw)

Conversation

ghost added the needs-area-label

An area label is needed to ensure this gets routed to the appropriate area owners

label

Jun 30, 2024

This was referenced

Jul 1, 2024

… EqualityComparer<string>.Default

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing lots of build errors, but they appear to be infra related?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed side changes LGTM.

/azp run runtime-nativeaot-outerloop

Azure Pipelines successfully started running 1 pipeline(s).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the naot test run passed with no failures related to this change)

stephentoub deleted the equalitycomparerdefaultalternate branch

July 2, 2024 01:39

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Reviewers

eiriktsarpalis eiriktsarpalis approved these changes

jkotas jkotas approved these changes

tannergooding tannergooding approved these changes

marek-safar Awaiting requested review from marek-safar

MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer Reviewers whose approvals may not affect merge requirements

Labels