More doc updates for source-of-truth assemblies by gewarren · Pull Request #107810 · dotnet/runtime (original) (raw)

gewarren changed the titleMore doc updates More doc updates for source-of-truth assemblies

Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed half of the files, until Microsoft.Extensions.FileProviders.

Next review starts at Microsoft.Extensions.Hosting.

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

1 similar comment

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for you to consider, otherwise it LGTM.
I'll backport this to release/9.0 as well when you merge it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the others:

@dotnet/area-extensions-logging does this default value begin in lowercase?

It would be nice to backport this to 9.0. Today's the snap for the RC2 branch but we still have time tomorrow before we start the builds. Would you mind looking at the feedback when you get a chance @gewarren?

Co-authored-by: Carlos Sánchez López 1175054+carlossanlop@users.noreply.github.com

This was referenced

Sep 17, 2024

@carlossanlop There seem to be a lot of errors. Is this okay to merge?

@carlossanlop backporting to release/9.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: doc updates Using index info to reconstruct a base tree... M src/libraries/Microsoft.Extensions.FileProviders.Abstractions/src/IFileProvider.cs M src/libraries/Microsoft.Extensions.FileProviders.Composite/src/CompositeFileProvider.cs M src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs M src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs M src/libraries/Microsoft.Extensions.Hosting/src/HostingHostBuilderExtensions.cs M src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs Falling back to patching base and 3-way merge... Auto-merging src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs CONFLICT (content): Merge conflict in src/libraries/Microsoft.Extensions.Primitives/src/StringValues.cs Auto-merging src/libraries/Microsoft.Extensions.Hosting/src/HostingHostBuilderExtensions.cs Auto-merging src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFilesWatcher.cs Auto-merging src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs Auto-merging src/libraries/Microsoft.Extensions.FileProviders.Composite/src/CompositeFileProvider.cs CONFLICT (content): Merge conflict in src/libraries/Microsoft.Extensions.FileProviders.Composite/src/CompositeFileProvider.cs Auto-merging src/libraries/Microsoft.Extensions.FileProviders.Abstractions/src/IFileProvider.cs CONFLICT (content): Merge conflict in src/libraries/Microsoft.Extensions.FileProviders.Abstractions/src/IFileProvider.cs error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config advice.mergeConflict false" Patch failed at 0001 doc updates Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@carlossanlop an error occurred while backporting to release/9.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})