fixes mac.binary subtype handling accross insert/archive/prune functions by FelixErnst · Pull Request #89 · eddelbuettel/drat (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks fine in principle though wholesale removal of a formerly used function always makes me a little nervous.
@mbjones @jankatins Your names are still in the comment of the function this PR would remove / streamline over. The reasoning is good; but just in case you still use drat
with macOS binaries your feedback would be welcome. If you no longer use drat
or this functionality no worries. Input, if you have any, still appreciated.
We may merge this and test it then but aren't in a terrible hurry.