Port coroutines to EMTERPRETIFY_ASYNC by atrosinenko · Pull Request #6014 · emscripten-core/emscripten (original) (raw)

Looks good, thanks!

In the future, I think it's usually easier to merge than to rebase in PRs. The merge itself is easier, and then the new diff in the PR is also clearer. Before github had the squash option it was better to rebase, but now if you squash it's the same anyhow, so merging is fine.

Odd that test takes 6 seconds - the emterpreter is slow, but I didn't think that test did that much work. Might be worth shortening it later.

No need to mark the new tests here, we do want them to run in other modes (and we enable emterpreter in them, that way we test more things).