Support grouped choices. by tomchristie · Pull Request #3225 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits8 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This also adds support for mixing single and paired choices:

[
    ('poor', 'Poor quality'),
    'medium',
    ('good', 'Good quality'),
]

@maxpeterson - We could consider something like #3101 as a follow up to this. I chose not to push that in as part of this change as a consequence of it being unclear what behavior we'd want (or even if we do want that behavior). As you mentioned:

I am not certain what the behaviour should be

I think the bottom line might be that we wouldn't accept further complications to the already ad-hoc 'OPTIONS' behavior, however I'd be willing to consider a fresh ticket for it if you were so minded and wanted to discuss further.

tomchristie added a commit that referenced this pull request

Aug 6, 2015