HTML rendering for filters by tomchristie · Pull Request #3315 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits9 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Closes #2180.

Filters rendering in the browsable API and admin.

Remaining:

Docs.
Use translated strings throughout.
Render bootstrap forms directly, dropping the crispy forms optional req.
Consider search control rendering directly? (But could be a second pass)

This sort of thing...

@tomchristie looking great, any specific reason for introducing the requirement for crispy forms?

@jpadilla django-filters won't render nicely with our bootstrap style out-of-the-box.

We'd probably be making it a soft requirement, but there's also a poss of moving DjangoFilterBackend into a third party package, and then including a built-in field filtering class that uses serializers (since they actually have everything we'd need to make this work).

there's also a poss of moving DjangoFilterBackend into a third party package

I'd be happy to maintain such a package.

I have a slight niggle about re-creating functionality that already exists; the prejudice is to consolidate effort rather than split it...

I'd be happy to maintain such a package.

That would be pretty amazing. Ideally I'd like to see us do that with both django-filter and django-guardian so that external deps are only required in external packages.

OK. Fine. I'll put something together.

Conflicts: rest_framework/compat.py rest_framework/filters.py

tomchristie added a commit that referenced this pull request

Oct 22, 2015

First pass at HTML rendering for filters

tomchristie changed the title~~First pass at HTML rendering for filters~~ HTML rendering for filters

Oct 22, 2015

This was referenced

Mar 9, 2017

This was referenced

Oct 6, 2017

This was referenced

Oct 16, 2017