#3228 - add confirm modal for delete by awwester · Pull Request #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Added a modal to confirm deletion of data

@awwester this is great! Mind putting together a screenshot or gif? Might also be a good idea to wrap new strings in a {% trans %} template tag`.

This is my first time working with translations and although the code seems correct comparing with other instances, I'm having issues getting a positive test to be sure. I've added a couple settings according to http://www.django-rest-framework.org/topics/internationalization/#enabling-internationalized-apis but can't get my app to switch into spanish for testing.

  # settings.py
  MIDDLEWARE_CLASSES = (
    'django.middleware.locale.LocaleMiddleware',
    ...
  )
  LANGUAGE_CODE = 'es-es'

is there something I'm missing?

@awwester sorry for the delay. To move this forward faster, I'd say forget about adding translation tags, drop the django.po. After that this is good to merge.

@jpadilla The trans changes have been reverted

jpadilla added a commit that referenced this pull request

Dec 1, 2015

#3228 - add confirm modal for delete

This was referenced

Mar 9, 2017

#3228 - add confirm modal for delete by awwester · Pull Request #3662 · encode/django-rest-framework (original) (raw)

Conversation