Fix handling of ALLOWED_VERSIONS and no DEFAULT_VERSION by blueyed · Pull Request #4370 · encode/django-rest-framework (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When only ALLOWED_VERSIONS but no DEFAULT_VERSION is specified, a
version should be enforced. When changing this, no existing tests were
failing. This adds tests for the fixed behavior.
The old behavior can be restored by adding None explicitly toALLOWED_VERSIONS.
When only ALLOWED_VERSIONS but no DEFAULT_VERSION is specified, a
version should be enforced. When changing this, no existing tests were
failing. This adds tests for the fixed behavior.
The old behavior can be restored by adding None explicitly to
ALLOWED_VERSIONS.
Not amended correctly.RequestVersionView existed already.. :)
Please squash-merge it into a single commit then, or let me know if I should fix it up / amend it correctly.
Yup, looks good - thanks!
2 participants
