Reload for prefetch_related updates may fail if object is filtered out. · Issue #4661 · encode/django-rest-framework (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Description

In the awkward case where prefetch_related has been applied to an update operation, we are required to refresh the instance from the database (see #4553)

The current implementation re-calls get_object(). We should instead call refresh_from_db directly on the model instance. This means that we don't have a potential case of get_object returning None because the update itself has effectively removed the object from the base queryset causing the lookup to fail.