Use strict float handling in JSON functions by rpkilby · Pull Request #5265 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits7 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Resolve #4918, fix #5235. The important bits that I gathered from the discussion were:

DRF should internally encode/decode only strict JSON, since other modules (eg, postgres's JSONField) may not be compatible with the extended float values (Infinity, NaN). Incompatible values should raise an exception.
Users may still want to render/parse extended JSON.

This PR does the following:

Adds an internal rest_framework.utils.json module that defaults to strict JSON encoding/decoding.
All imports have been changed to rest_framework.utils.json, so they obey the stricter behavior.
Adds flake8-tidy-imports, which allows us direct users to import the json wrapper module.
Adds settings.STRICT_JSON, which controls the strictness of JSONParser & JSONRenderer. This defaults to True, but users can revert to the old extended behavior by setting this to False

Ryan P Kilby added 4 commits

July 10, 2017 16:55

STRICT_JSON controls the renderer & parser behavior on whether or not to accept non-standard float values (NaN, Infinity).