Django 2.0a1 compat by carltongibson · Pull Request #5503 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Following from #5500, fixing failures against Django 2.0a1

@rpkilby There's a change in Django 2.0 which brings back issues around #4622. It's just a single failure now, but of course nothing about get_FOO_display in the release notes. Any thoughts?

@rpkilby They made get_FOO_display a functools.partial. Checking for this fixes the issue.

I'm trying to remember - is there a reason we don't just use a callable check there?

oh - right. Classes are also callables.

That said, I don't know if that really matters. Is there a reason to exclude classes here? Or other non-method/non-functions for that matter?

OK, this is green. Django2.0a1 is GO! 🎉

• I'll leave django20 as an allowed failure for now. We can tighten up nearer release.
• There's only a small number of failures on djangomaster — looks like the contrib.auth views are on the move.

This is where we wanted to be for today.

@rpkilby Thanks for the input!

2 participants