Update bootstrap to 3.4.1 by Maxyme · Pull Request #6923 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Maxyme

@tomchristie

Thanks!

@encode/django-rest-framework - we ought to validate the SHA of the .min.js against the hosted file whenever we're updating a dependency like this.

I'm happy to make time for this or to have someone else take it on - what are our thoughts (if any) on timings for the next release?

@shrew4u2do

+1 for merging this one in

auvipy

@jpadilla

Regarding #6923 (comment), a possible approach to process here would be to have a bash script with versions/urls pointing to dependency sources. In order to update one of these dependencies, we would update the version/url and run script to download. Same script could be run in CI to compare SHAs. I could help with introducing something like this.

--

$ curl -s https://raw.githubusercontent.com/encode/django-rest-framework/d6c24df9679cad1402243e90e565fea468b5a121/rest_framework/static/rest_framework/js/bootstrap.min.js | shasum -a 256
9ee2fcff6709e4d0d24b09ca0fc56aade12b4961ed9c43fd13b03248bfb57afe  -

$ curl -s https://stackpath.bootstrapcdn.com/bootstrap/3.4.1/js/bootstrap.min.js | shasum -a 256
9ee2fcff6709e4d0d24b09ca0fc56aade12b4961ed9c43fd13b03248bfb57afe  -

jpadilla

@Maxyme Maxyme deleted the update_bootstrap_3_4_1 branch

November 25, 2019 20:50

rubendv pushed a commit to Awingu/django-rest-framework that referenced this pull request

Aug 11, 2020

@Maxyme @rubendv

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request

Nov 17, 2020

@Maxyme

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request

Dec 3, 2022

@Maxyme @sigvef