Fix in UniqueTogetherValidator to allow it to handle querysets by miki725 · Pull Request #2575 · encode/django-rest-framework (original) (raw)

Im not sure if this issue can be easily demonstrated in DRF by itself since ListSerializer does not define update() which is where the issue happens. I created a test case in DRF-bulk to test for this since there I do overwrite update() in ListSerializer. Here are some resources to look at.

• the test - source. You can see travis failure here
• ListSerializer.update() implementation - source. Notice that I use use a child serializer's update() implementation which in this case is implementation from ModelSerializer.
• View.perform_bulk_update() - source. this simply calls serializer.save() so nothing special is going on.

The issue might be in DRF-bulk, specifically in ListSerializer.update() but I do not do anything special there so some pointer on fixing that would be appreciated. If the issue however is in DRF3 and this PR approach is not appropriate, what would be your recommendation?

EDIT: just realized that ListSerializer.update() is never called and that error happens during serializer.is_valid(). Guess I still need to wake up.... Tonight Ill send you a gist or something trying to reproduce an error in vanilla DRF3.