make get_reference public by n2ygk · Pull Request #7515 · encode/django-rest-framework (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Description
Makes schemas.openapi.get_reference public (remove the _) to complement making other methods public such as get_component_name()
It's not immediately obvious to me when this'd be useful to have as public API, since it only makes sense to use if you've got references outside of the standard '$ref': '#/components/schemas/{...} space.
Are you able to provide some kind of slimmed down example that'd require this as public API?
Okay, so... making it public not because you want to override the behaviour in it, but rather, making it public because your implementation needs to call it? That makes sense I guess.
Contributor Author
n2ygk commented
via email
• Loading
Yep. Maybe do the same for _initialise_endpoints? I just prefer not to have to rely on private APIs. I can submit a PR for that as well or add it to this one if you prefer.
@carltongibson perhaps you can review this and put it on Tom's queue for 3.13?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This stalebot stuff makes me sad that I wasted effort on submitting PRs.
This seems reasonable enough, yes.
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request
2 participants
