Properly handle OverflowError in DurationField deserialization by peterthomassen · Pull Request #8042 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I think this is still current.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I think this is still current.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I think this is still current.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have recently merged an identical feature for another field #8725. can you cross check and make amendment accordingly to this PR?

The code looks very similar to me. Which according amendments do you mean? (Would you like to change the logic, or the error message? (Number of days out of range, must be between {min_days} and {max_days}.)

btw, having another look, it seems your code is quite right. can you please pull from master so that the CI triggers with latest changes?

thank you for your patience

2 participants