Represent SafeString as plain string on schema rendering. by hashlash · Pull Request #8429 · encode/django-rest-framework (original) (raw)
I tried running tox -e docs on branch master, and it also failed (with the same error). So the problem shouldn't be from the changes in this PR.
Should we wait for the fix, or can we merge it first?
The error should be fixed in #8433.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much depth regarding yaml. will be waiting for more eyes into this. on a side note, can you add more relevant tests for the changes?
can you add more relevant tests for the changes?
@auvipy I think the test is sufficient. As long as it can render SafeString, I think it's good enough.
Or could you elaborate on what kind of test I should add?
I have requested review from another OpenAPI specialist
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you're right. I just read the discussion #8453, but wasn't aware with the drf-spectacular renderer implementation. Based on the discussion, going forward, the renderer part will also be deprecated from rest_framework?
@hashlash, yes. everything that does not belong to the schema interface itself will be retired and removed eventually.