Upgraded Bootstrap to 3.4.1 and added CSS source maps by adamchainz · Pull Request #8591 · encode/django-rest-framework (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #8587. 3.4.1 has a few changes including an XSS security fix. Adding the CSS source maps will allow DRF to be used with Django 4.1 and ManifestStaticFilesStorage.
Python 3.9 failure is from master.
@adamchainz I played a bit with the issue and I found out the failing CI is because there are extra tests only for Python 3.9 which use a built version of DRF. The files included during the build are defined in MANIFEST.in and files with .css.map are not included. You need to modify the following line and add *.css.map
| recursive-include rest_framework/static *.js *.css *.png *.ico *.eot *.svg *.ttf *.woff *.woff2 |
|---|
You can check the CI runs on my branch: https://github.com/KOliver94/django-rest-framework/pull/1
Thank you, I"ve added to MANIFEST.in.
Ah I didn't read the logs enough, the failure on master was due to the missing source map:
dist run-test: commands[0] | ./runtests.py --no-pkgroot --staticfiles
Post-processing 'rest_framework/css/bootstrap-theme.min.css' failed!
...
INTERNALERROR> raise ValueError(
INTERNALERROR> ValueError: The file 'rest_framework/css/bootstrap-theme.min.css.map' could not be found with <django.contrib.staticfiles.storage.ManifestStaticFilesStorage object at 0x7fba9b07da60>.
Fantastic. Thanks all. 🙏🏼
How do I fix this in my project? Cant run collectstatic/
I think this fix hasn't been released yet. You can:
- Wait for the release
- Downgrade to Django 4.0
- Use the development version (not recommended)
You can also add source map files, even empty ones, to your project's static folder. Use the right file names: rest_framework/static/rest_framework/css/bootstrap-theme.min.css.map and rest_framework/static/rest_framework/css/bootstrap.min.css.map
from cli calling heroku config:set DISABLE_COLLECTSTATIC=1 is also an option
from cli calling
heroku config:set DISABLE_COLLECTSTATIC=1is also an option
This is not a good idea as it will break static assets for most projects.
For those of you sniffing around for a quick fix, here's a reasonably portable one-liner that will touch .map files for all of the minified CSS provided by DRF:
find "$(python -c 'import rest_framework as rf; print(rf.path[0])')" -name '*.min.css' -exec touch '{}.map' ;
And if you're just really itchin' for those sweet, sweet sourcemaps, you can incant the following curse:
(
cd "$(python -c 'import rest_framework as rf; print(rf.path[0])')" &&
curl -fsSL "https://github.com/encode/django-rest-framework/archive/refs/heads/master.tar.gz"
| tar --extract --gzip --wildcards --strip-components=2 '*.map'
)
Oh, and here's that comment you'll forget to write the moment it starts working:
# HACK: Work around a compatibility issue between Django Rest Framework and Django 4.1
#
# * Django 4.1 introduces a change to ManifestStaticFilesStorage that replaces CSS source
# map references in static files [0].
# * Django Rest Framework vendors bootstrap CSS files which reference sourcemaps, but
# does not include them in the installed package's static files [1].
#
# TODO: Remove this hack when a new version of Django Rest Framework is released containing
# the fix [1]
#
# [0] https://docs.djangoproject.com/en/4.1/releases/4.1/#django-contrib-staticfiles
# [1] https://github.com/encode/django-rest-framework/pull/8591
wizpig64, decibyte, mrharpo, benhowes, akx, hiAndrewQuinn, setnoset, jnns, theletterjeff, philippbosch, and 3 more reacted with heart emoji wizpig64, Noughmad, and jerivas reacted with rocket emoji
@adamchainz Is there a plan to make a new release with this fix?
Yes, #8599 is where that is happening.
@adamchainz Thank you so much 🌷 I couldn't find that, sorry.
I ran into this issue as well, while working through @wsvincent 's excellent Django for APIs book. My fix was somewhat complicated because I was also working within a Poetry environment.
My fix was to downgrade to 4.0.
Rip Django out, and add a version which will stay at the latest 4.0.whatever.
poetry remove django poetry add "django==~4.0" # thatnks @adamchainz poetry update
Check that your repo's Django version is now, in fact, 4.0.whatever.
poetry run python -m django --version
Try this again.
poetry run python manage.py collectstatic
(For anyone reading in the future, this fix comes around Chapter 4, "Library API", right when we have to start adding in whitenoise.)
@hiAndrewQuinn Downgrading is probably the right approach there. Does the book not reccomend using a specific Django version from the start though? I know Will only advertises the book as updated for Django 4.0 at current.
Also a tip, you don't want to use Django 4.0.0, but instead 4.0.7, which is the latest release in the 4.0 series. It has a bunch of security and bug fixes. See the 4.0.7 release notes, and the previous linked versions. If you don't use the latest release of a given series, you may encounter already-fixed bugs, which is just frustrating.
He does, and you are correct. I edited my code to reflect that for any future wannabe Djangoists.
theletterjeff added a commit to theletterjeff/gin-rummy-scoresheet that referenced this pull request
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request
chriswedgwood added a commit to AaLondon/aalondon that referenced this pull request
