Use correct class to indicate present deprecation by DavidCain · Pull Request #8665 · encode/django-rest-framework (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

PendingDeprecationWarning means "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it is deprecated.

Base class for warnings about features which are obsolete and expected
to be deprecated in the future, but are not deprecated at the moment.

This class is rarely used as emitting a warning about a possible
upcoming deprecation is unusual, and DeprecationWarning is preferred for
already active deprecations.

(emphasis mine)

https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning

PendingDeprecationWarning means "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it is deprecated.

Base class for warnings about features which are obsolete and expected to be deprecated in the future, but are not deprecated at the moment.

This class is rarely used as emitting a warning about a possible upcoming deprecation is unusual, and DeprecationWarning is preferred for already active deprecations.

https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request

Dec 3, 2022

PendingDeprecationWarning means "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it is deprecated.

Base class for warnings about features which are obsolete and expected to be deprecated in the future, but are not deprecated at the moment.

This class is rarely used as emitting a warning about a possible upcoming deprecation is unusual, and DeprecationWarning is preferred for already active deprecations.

https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning

Co-authored-by: Tom Christie tom@tomchristie.com