Drop deprecated AutoSchema._get_reference method by browniebroke · Pull Request #9525 · encode/django-rest-framework (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks7 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Description
In preparation for the upcoming 3.16 release, drop AutoSchema._get_reference method which is marked as RemovedInDRF316Warning.
The warning class is now unused, so dropping that as well (shouldn't be needed with DRF 3.16).
As well the unused RemovedInDRF316Warning
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anything related to this to e removed?
is there anything related to this to e removed?
Is that a question for me? If so, I'm not sure I understand what is being asked, but FWIW I searched for references of this method in the DRF codebase/docs and couldn't find any.
There doesn't seem to be anywhere in the codebase where the removed method is being referenced.
The removed warning class also doesn't appear to be referenced anywhere in the entire codebase.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be before/after the release of next major version