SeerMainWindow: Change action buttons when status changed by QuangNguyenMinh123 · Pull Request #423 · epasveer/seer (original) (raw)

@QuangNguyenMinh123

@epasveer

You're probably right. But there's more menu bar items to disable, including some from the Control menu and others....

image

@epasveer

I'm going to hold off on this one for a while. I'm making changes to the menus. So doing this, on a bigger scale, can be done later.

@QuangNguyenMinh123

Can this MR be merged soon?

@epasveer

@epasveer

These buttons/menus need disabling when the program is running.

image image

@QuangNguyenMinh123

Currently, I face a problem:
Some action buttons won't return to default state (enable) when a gdb process is terminated during debug. Please see bellow image
image
Though these button state will be normal when a new gdb session is started, so this isn't a big issue

@QuangNguyenMinh123

Another problem is dealing with action Record and Record Direction
I have never used these buttons
When I enable Record and set Direction and run (Continue F8) the program, at some points, I will no longer to stop the program (interrupt)
To reproduce:

  1. start a new debug session
  2. continue f8
  3. interrupt
  4. enable record (click on Record button)
  5. continue f8, press until program run (in my PC, I need 2 clicks). Check status bar on lower right of Seer
  6. now, try to stop program by interrupt it, but interrupt won't change program from running to stopped -> issue is reproduced

@QuangNguyenMinh123

Another problem is dealing with action Record and Record Direction I have never used these buttons When I enable Record and set Direction and run (Continue F8) the program, at some points, I will no longer to stop the program (interrupt) To reproduce:

  1. start a new debug session
  2. continue f8
  3. interrupt
  4. enable record (click on Record button)
  5. continue f8, press until program run (in my PC, I need 2 clicks). Check status bar on lower right of Seer
  6. now, try to stop program by interrupt it, but interrupt won't change program from running to stopped -> issue is reproduced

Regarding this issue, I checked out the main branch of Seer to try to reproduce it. It turns out the issue still exists even on the main branch

@epasveer

Hi @QuangNguyenMinh123

I've thought about this some more. Lets go back to your original way.

When the program is running, disable the continue/step/next/stepi/nexti/finish buttons on the Control Menu and the Tool Bar. Then re-enable them when a break point is reached.

For the Record/Visualizer buttons, just leave them as they were. If users want these, we can pursue this later.

@epasveer

Regarding this issue, I checked out the main branch of Seer to try to reproduce it. It turns out the issue still exists even on the main branch

Okay, cool. I'll create a separate issue and will on this myself.

Oh, and thanks for the steps to reproduce the problem.

@QuangNguyenMinh123

@QuangNguyenMinh123

@epasveer

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})