Removed unneeded undef min|max, they no longer clash with vector et al by devyte · Pull Request #3856 · esp8266/Arduino (original) (raw)

@igrr I need a bit of help with this one. I wanted to remove two remaining #undef min|max left over from before the Arduino.h fix submitted some days ago (see top commit above), but Travis failed when building tests. To my surprise, I found another Arduino.h in there, which has fallen behind vs. the core one. I tried bringing it somewhat to par with the current Arduino.h, specifically with the min|max fix, but the build still fails, this time complaining about isnan etc already defined.
Oddly, if I run make under tests/host locally in my Ubuntu machine, it builds fine.
At this point, I suspect an issue with the version of gcc. Travis builds with 4.8.4, while my linux box has 5.4.0.
How can I remove the two #undef min|max without breaking the build?